Updates to right sidebar #2279
Merged
Updates to right sidebar #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
position is borked
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
approved these changes
Aug 15, 2022
| @@ -47,6 +47,15 @@ | |||
| (:username current-user))) | |||
|
|
|||
|
|
|||
| (rf/reg-sub | |||
| :presence/user-page | |||
| :<- [:presence/current-username] | |||
There was a problem hiding this comment.
I think what should happen here is :presence/current-username returns You when in PKM. That way other features get this behaviour automatically.
But other features might already be checking if PKM or CKM as well so this refactor might be a bit harder. I think I'll tackle it in another PR.
| (fn [e] (router/navigate-uid uid e))) | ||
| :onClickOpenInSidebar (when-not (contains? @(subscribe [:right-sidebar/items]) uid) | ||
| #(dispatch [:right-sidebar/open-item uid]))} | ||
| [:> PageHeader {:onClickOpenInSidebar (when-not @(subscribe [:right-sidebar/contains-item? [:block/uid uid]]) |
There was a problem hiding this comment.
Is onClickOpenInMainView not supported here anymore?
There was a problem hiding this comment.
Yes, it should be removed, except on daily notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@{{presence-name}}to store the sidebar state. uses@Youif in PKMonClickOpenInMainViewto always be in the right sidebar item, rather than within the embedded page view of right sidebar item'shttps://www.loom.com/share/68de592360b946efa2dae202eb9e0741?focus_title=1&muted=1&from_recorder=1