Fix db dialog issues #2290
Merged
Fix db dialog issues #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shanberg
commented
Aug 19, 2022
shanberg
commented
- Fixes focus-fighting warning in db popover
- Removes buttons to remove in-memory db for now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
approved these changes
Aug 19, 2022
| @@ -1,11 +1,11 @@ | |||
| (ns athens.electron.db-menu.core | |||
| (:require | |||
| ["@chakra-ui/react" :refer [Box IconButton Spinner Text Tooltip Heading VStack ButtonGroup PopoverTrigger ButtonGroup Popover PopoverContent Portal Button]] | |||
| ["react-focus-lock" :default FocusLock] | |||
There was a problem hiding this comment.
Need to remove the dep, this was its last use.
| @@ -14,14 +14,23 @@ | |||
|
|
|||
| (defn current-db-tools | |||
| ([{:keys [db]} all-dbs merge-open?] | |||
| (prn db all-dbs) | |||
| [athens.electron.db-menu.db-icon :refer [db-icon]] | ||
| [athens.electron.db-menu.db-list-item :refer [db-list-item]] | ||
| [athens.electron.db-modal :as db-modal] | ||
| [athens.electron.dialogs :as dialogs] | ||
| [athens.electron.utils :as electron.utils] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.