-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: wait to update sidebar size on graph #2321
Conversation
shanberg
commented
Aug 27, 2022
- Right sidebar resizes with frontend state, saves to graph after a second
- Layout animation is disabled while resizing
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the graph can break in its current state, and you should be able to recover alignment by dragging the bar a tiny bit, I think this shouldn't block merging |
I don't think we have full certainty that this broke the graph, though one followed the other. It might've, but the root issue still hasn't been solved from a data perspective. |
The other thing is that I think there is probably a more generic way to be doing this, because I think we might have this pattern again. |