Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: wait to update sidebar size on graph #2321

Merged
merged 8 commits into from
Sep 1, 2022

Conversation

shanberg
Copy link
Collaborator

  • Right sidebar resizes with frontend state, saves to graph after a second
  • Layout animation is disabled while resizing

@vercel
Copy link

vercel bot commented Aug 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 10:41PM (UTC)

Copy link
Collaborator

@tangjeff0 tangjeff0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I resize the right sidebar very quickly, there's some lag, which causes the ResizeController to have different final width than the other layout elements:

image

@shanberg shanberg changed the title Sidebar resize perf perf: wait to update sidebar size on graph Aug 29, 2022
@shanberg
Copy link
Collaborator Author

When I resize the right sidebar very quickly, there's some lag, which causes the ResizeController to have different final width than the other layout elements:

image

Given that the graph can break in its current state, and you should be able to recover alignment by dragging the bar a tiny bit, I think this shouldn't block merging

@tangjeff0
Copy link
Collaborator

Given that the graph can break in its current state

I don't think we have full certainty that this broke the graph, though one followed the other. It might've, but the root issue still hasn't been solved from a data perspective.

@tangjeff0
Copy link
Collaborator

The other thing is that I think there is probably a more generic way to be doing this, because I think we might have this pattern again.

@shanberg shanberg merged commit 330da8c into athensresearch:main Sep 1, 2022
@shanberg shanberg deleted the sidebar-resize-perf branch September 1, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants