Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaner task renderer #2323

Merged
merged 7 commits into from
Aug 29, 2022
Merged

leaner task renderer #2323

merged 7 commits into from
Aug 29, 2022

Conversation

shanberg
Copy link
Collaborator

@shanberg shanberg commented Aug 28, 2022

Todo:

  • Updating task status should update task status on graph
  • Taskbox should receive more detailed options via props

@vercel
Copy link

vercel bot commented Aug 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Aug 29, 2022 at 1:28PM (UTC)

@@ -458,9 +462,7 @@
status-ref (str "((" new-status "))")]
(rf/dispatch [:graph/update-in [:block/uid parent-block-uid] [":task/status"]
(fn [db uid] [(graph-ops/build-block-save-op db uid status-ref)])])))]
(prn status-string)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this println for the life of me.
Thank you for removing it.

(when (and show-description? description)
[:> Text {:fontSize "sm" :flexGrow 1 :flexBasis "100%" :m 0 :py 1 :lineHeight 1.4 :color "foreground.secondary"}
description])
#_(when (and show-description? description)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really missing this part of UI

@neotyk neotyk merged commit 4ee42b4 into athensresearch:main Aug 29, 2022
@neotyk neotyk deleted the lean-task branch August 29, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants