Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidebar tasks widget #2359

Merged
merged 22 commits into from
Sep 14, 2022
Merged

Conversation

shanberg
Copy link
Collaborator

@shanberg shanberg commented Sep 8, 2022

Major

  • Task status can be changed from the tasks widget
  • Sidebar footer is sticky, so always appears on screen

Minor

  • Number of incomplete tasks assigned to me shown per page
  • Don't show the % complete on pages because it’s unclear what 100% means (my tasks vs all tasks on that page)
  • Improved layout and options for tasks display settings/filter control
  • Filter out pages with all tasks completed
  • Task appear/disappear more smoothly

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 1:39PM (UTC)

Copy link
Collaborator

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see an error when using in PKM mode:

  • open the vercel url
  • make a bullet with text
  • convert to task
react_devtools_backend.js:4026 TypeError: Cannot read properties of null (reading 'D')
    at u9a (app.js:8316:427)
    at Function.<anonymous> (app.js:8878:255)
    at Eba (app.js:5058:459)
    at Dba (app.js:5058:380)
    at Cba (app.js:5058:295)
    at Qg (app.js:5064:122)
    at eOa (app.js:6432:49)
    at app.js:6433:466
    at GNa (app.js:6400:351)
    at g._run (app.js:6415:260)

@shanberg
Copy link
Collaborator Author

@filipesilva I'm only seeing that issue on the Vercel build, not when using the in-memory graph locally. Any idea why that could be?

@filipesilva
Copy link
Collaborator

filipesilva commented Sep 14, 2022

I think the reason it appears on vercel but not locally is related (but not wholly attributed to) the currently enabled feature flags.

@filipesilva
Copy link
Collaborator

Fixed the previous error

@filipesilva filipesilva merged commit dde75ef into athensresearch:main Sep 14, 2022
@shanberg shanberg deleted the improve-task-ui branch September 16, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants