Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arrow #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Arrow #48

wants to merge 2 commits into from

Conversation

ManoRanjithK
Copy link

I've added a new TV series Arrow to the repo. I'll add a few more series in upcoming months.

Copy link
Owner

@athityakumar athityakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ManoRanjithK. Thanks a lot for sending this PR. Please have a look at my suggestions -

  • Only season 1 of Arrow seems to have been added.
  • You don't have to add the json file manually. Rather, just write a scraper function in the auto/ruby/index.rb file and all seasons will be written into HTML files.
  • I don't see any difference in the accordion.less file. Can you revert it?

@ManoRanjithK
Copy link
Author

Hey @athityakumar Alright I will make those changes and let you know.

@ManoRanjithK
Copy link
Author

@athityakumar , I get the following error message when I run the ruby script. Can you help me out?
pic

@chamow97
Copy link
Contributor

chamow97 commented Dec 8, 2017

Had the same issue.
Do these things:

  1. From auto/data isolate, bb.json, totl.json
  2. Comment out the same from index.json
  3. Comment out the following methods from auto/ruby/index.rb
    -bb_scraper
    -totl_scraper
    -sitemap methods(there are few, easy to find)
    PS: It ran for me after these changes. Get confirmation from @athityakumar before proceeding though.

@athityakumar
Copy link
Owner

@ManoRanjithK - You can definitely try fixing the existing issue (recommended) - that way, you make life easier for future contributors. But if you aren't sure of debugging, feel free to follow what @chamow97 has written above.

@ManoRanjithK
Copy link
Author

ManoRanjithK commented Dec 9, 2017

@athityakumar I've reverted back that accordion.less file and I've removed sitemap from README.md as in issue #44 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants