-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Arrow #48
base: master
Are you sure you want to change the base?
Added Arrow #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ManoRanjithK. Thanks a lot for sending this PR. Please have a look at my suggestions -
- Only season 1 of Arrow seems to have been added.
- You don't have to add the json file manually. Rather, just write a scraper function in the auto/ruby/index.rb file and all seasons will be written into HTML files.
- I don't see any difference in the accordion.less file. Can you revert it?
Hey @athityakumar Alright I will make those changes and let you know. |
@athityakumar , I get the following error message when I run the ruby script. Can you help me out? |
Had the same issue.
|
@ManoRanjithK - You can definitely try fixing the existing issue (recommended) - that way, you make life easier for future contributors. But if you aren't sure of debugging, feel free to follow what @chamow97 has written above. |
@athityakumar I've reverted back that accordion.less file and I've removed sitemap from README.md as in issue #44 . |
I've added a new TV series Arrow to the repo. I'll add a few more series in upcoming months.