[WIP] Refactor code to gem #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athityakumar
force-pushed
the
refactor-code-to-gem
branch
2 times, most recently
from
73de58e to
924043a
Compare
athityakumar
commented
Mar 6, 2018
| IMDB_LINK = 'http://www.imdb.com/title/tt4532368/'.freeze | ||
| SCRAPE_LINK = 'https://en.wikipedia.org/wiki/List_of_Legends_of_Tomorrow_episodes'.freeze | ||
| JSON_FILE_PATH = File.join(TVSeries::SERIES_JSON_PATH, 'legends_of_tomorrow.json').freeze | ||
| SHORT_NAME = 'lot'.freeze |
There was a problem hiding this comment.
For all scraper classes, store just the series_name (short name) and access other details from the base.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution
Refactors the entire codebase with proper community standards.