Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add id to cse7766/hlw8012 sensor entries, so they can be overridden #116

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

tabrisnet
Copy link

this is related to #115. it should be generally harmless, but allow overrides to be placed on the sensor entries.

@Roving-Ronin
Copy link

@tarontop / @athom-tech

Aiden, from prior #115 this request in short is to add the 'id:' tag to the CSE7766 and HLW8012 sensor components. This is as he wants to remove these official sensors from his own deployments and replace with his own version of the sensors. IMHO don't see any benefit to reducing frequency of data from these sensors, but this would allow him to do so easily and wouldn't affect anyone else anyhow.

+! Approve.

@tabrisnet tabrisnet marked this pull request as ready for review December 30, 2024 02:41
@tarontop tarontop merged commit 2dea530 into athom-tech:main Jan 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants