Bl0906 - Add default mdi icons to the sensors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roving-Ronin
commented
Aug 21, 2024
Roving-Ronin
commented
- Add default mdi icons to bl0906 sensors, i.e. Power, Frequency, Energy, Current, Temperature.
- These will then automatically populate in the ESPHome webserver view and also populate through to Home Assistant sensors icons, for each sensor.
- As some icons aren't already defined in the esphome const.py, these are added (mapping constant to an mdi icon) in the local const.py file.
- Add missing CodeOwners identification to the sensor.py
Add default mdi icons to sensors
Defines the ICON_ Constants to MDI icons, that are not already in the default const.py published at https://github.com/esphome/esphome/blob/dev/esphome/const.py
Missing CodeOwners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.