Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy-Monitors - Remove External Component for BL0906 #26

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Roving-Ronin
Copy link
Contributor

Remove external component for bl0906, as this has now been added to ESPHome in version 2024.9.0

Remove external component for bl0906, as this has now been added to ESPHome in version 2024.9.0
Remove external component for bl0906, as this has now been added to ESPHome in version 2024.9.0
@Roving-Ronin
Copy link
Contributor Author

@tarontop Could you please advise? I would have assumed the 'official' BL0906 (in ESPHome 2024.9.0 that you submitted) is THE version to use, however it fails the compile and checking the ESPHome file changes ( https://github.com/esphome/esphome/pull/7339/files ) there's differences in the files, from the original component in this repository.

???

@tarontop
Copy link
Collaborator

@tarontop Could you please advise? I would have assumed the 'official' BL0906 (in ESPHome 2024.9.0 that you submitted) is THE version to use, however it fails the compile and checking the ESPHome file changes ( https://github.com/esphome/esphome/pull/7339/files ) there's differences in the files, from the original component in this repository.

???

It seems that there is a problem with the official code

@Roving-Ronin
Copy link
Contributor Author

Roving-Ronin commented Sep 21, 2024

"It seems that there is a problem with the official code"

The version now in the official ESPHome release is MASSIVELY different to the version in this repository. Just looking and:

  • ESPHome version has a 'constants.h' file, whilst athom does not.
  • bl0906.cpp on ESPHome is 238 lines, athom version is 360 lines.
  • bl0906.h on ESPHome is 176 lines, athom version is 96 lines.
  • sensor.py on ESPHome is 184 lines, athom version is 176 lines.

Contents of the files is different in places, let alone the line differences.

@Roving-Ronin
Copy link
Contributor Author

ESPHome Issue Opened:  esphome/issues#6272

@tarontop tarontop merged commit 096b684 into athom-tech:main Oct 2, 2024
9 checks passed
@Roving-Ronin Roving-Ronin deleted the bl0906-use-ESPHome-2024-9 branch October 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants