Include capabilities for ACs

[stefan-schweiger]

If the capabilities are not included in driver.compose.json they will only get added once they are reported by the actual device. Added them statically to be available directly after adding a device.

[wouter-athom]

Hey @stefan-schweiger! We have purposely omitted the device capabilities from the driver.compose.json for the other drivers, since not all devices support all capabilities. This way, only the supported capabilities are added to the device.

[stefan-schweiger]

@wouter-athom I mean I kind of get the point, but I assume for an ac for example at least onoff, measure_temperature, target_temperature (and maybe even the operation mode) will always be available. Without it the capabilties are also not displayed on the store page which is a bit of a shame.

[stefan-schweiger]

@wouter-athom since I have no better way of contacting you as issues are disabled: it seems like samsung changed newly issued api tokens to only be valid for 24h and the app needs to use oauth going forward. Is this something on your radar?

https://community.smartthings.com/t/changes-to-personal-access-tokens-pat/292019

[wouter-athom]

If it's just the capabilities that are guaranteed to be present on all airconditioners, then this can be added. We would however like this to be consistent across all devices. If you are able to include the other devices in this pull request as well, I will approve it.

[wouter-athom]

@wouter-athom since I have no better way of contacting you as issues are disabled: it seems like samsung changed newly issued api tokens to only be valid for 24h and the app needs to use oauth going forward. Is this something on your radar?

https://community.smartthings.com/t/changes-to-personal-access-tokens-pat/292019

@stefan-schweiger Yes, this is something we are aware of and have been looking into. Thanks for letting us know either way!