Add support for Simple Icons #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still JS for the toggle functionality, but no more Javascript to refresh the icons.
This is based on https://github.com/simple-icons/simple-icons-font, release 13.3.0, with font and css copied in. Since Feather Icons and Simple Icons differ in purpose and naming scheme, old social icons still point to feather. To add simple icons, just prefix their name with "simple", e.g. - name: "mastodon" icon: "simple:mastodon" url: "https://foo.social/@foo" Resolves #69, #95, #49
athul
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the Simple Icons set.
Note that it's based on #116. If that one isn't accepted, I can rebase this to work with js-based feather, but I wanted to avoid having to deal with conflicts between the two changes in my local setup.