Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crash): wrong app entry point #17

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

FelipeEmos
Copy link
Contributor

Hi, @atilafassina

I've noticed the quantum app crashes as soon as I open it...

That's because SolidStart expects the entry point to be at src/app.tsx and the current project is using src/App.tsx. So this PR is just a renaming of that file, which fixes the issue 🙃

Steps to reproduce

  • Clone the repo
  • Run pnpm install && pnpm dev
  • Open the URL and you'll face the error message

Error Message

image

5:11:42 PM [vite] Internal server error: Failed to resolve import "#start/app" from "node_modules/.pnpm/@solidjs+start@1.0.1_rollup@4.18.0_solid-js@1.8.7_vinxi@0.3.12_@opentelemetry+api@1.9.0_@type_boxwf6i7jopexbi3kkefdqtuum/node_modules/@solidjs/start/dist/client/StartClient.jsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/felipe/Development/misc/fork-quantum/node_modules/.pnpm/@solidjs+start@1.0.1_rollup@4.18.0_solid-js@1.8.7_vinxi@0.3.12_@opentelemetry+api@1.9.0_@type_boxwf6i7jopexbi3kkefdqtuum/node_modules/@solidjs/start/dist/client/StartClient.jsx:3:16
  1  |  import { createComponent as _$createComponent } from "solid-js/web";
  2  |  import App from "#start/app";
     |                   ^
  3  |  import { ErrorBoundary } from "../shared/ErrorBoundary";
  4  |  import "./mount";

@FelipeEmos FelipeEmos changed the title fix: wrong app entry point fix(crash): wrong app entry point Jul 26, 2024
Copy link
Owner

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 Can't believe I missed that on the previous PR!
thanks a lot @FelipeEmos !!

@atilafassina atilafassina merged commit 0b0c18f into atilafassina:main Jul 28, 2024
@FelipeEmos FelipeEmos deleted the fix/app-endpoint branch August 1, 2024 02:05
@FelipeEmos
Copy link
Contributor Author

You're welcome, bro!
Thanks for the project template 🙌🏻

@atilafassina
Copy link
Owner

@all-contributors please add @FelipeEmos for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@atilafassina

I've put up a pull request to add @FelipeEmos! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants