Leak fix

[denizzzka]

I think this is the reason of crashes:

clang_disposeIndex() - Destroy the given index.

The index must not be destroyed until all of the translation units created within that index have been destroyed.

[denizzzka]

TranslationUnit pointer stored inside of each Cursor struct to avoid destruction before cursors using it destroyed. To avoid giant changes for Cursor interface TranslationUnit pointer bypassed to each Cursor inside of unused variable CXTranslationUnitImpl.CommentToXML

Tested with ~master dpp

[denizzzka]

clang from 14 to at least 19 uses same struct

[atilaneves]

Why do we need the definition of it though?

[denizzzka]

To hide store pointer to the TranslationUnit inside of one of the unused fields (CommentToXML), so that this pointer is accessible to any cursor created from CXTranslationUnit

[denizzzka]

Other ways involve massive Cursor interface changes

[atilaneves]

We would change the interface of a type that's from libclang??

[denizzzka]

Why is that?

As I remember, Cursor becomes mutable and it is leads to changes in almost all functions what use Cursor

[aminya]

It would be counter productive to mark code with opaque memory leaks as safe.
Regarding the supported version, that can be easily resolved by bumping the major version. There's no point in supporting old libclang libraries.

[denizzzka]

It would be counter productive to mark code with opaque memory leaks as safe.

This is a reason for another PR, there is no need to clutter this PR

[aminya]

I meant that it's better to rely on the definition to fix the memory leaks instead of trying to keep the library compatible with older versions of libclang.

[denizzzka]

instead of trying to keep the library compatible with older versions of libclang.

I don't have such a goal - I'm only worried about the interface changes that affect dpp (it heavy uses libclang)

[atilaneves]

Why do we need the definition of it though?