Add support for stacked bar chart #17
Conversation
mvorisek
force-pushed
the
feature_stacked_bar_chart
branch
from
c8dc50d to
0b15108
Compare
mvorisek
changed the title
| @@ -28,11 +28,15 @@ class Chart extends View | |||
| ['rgba(75, 192, 192, 0.2)', 'rgba(75, 192, 192, 1)'], | |||
| ['rgba(153, 102, 255, 0.2)', 'rgba(153, 102, 255, 1)'], | |||
| ['rgba(255, 159, 64, 0.2)', 'rgba(255, 159, 64, 1)'], | |||
| ['rgba(20, 20, 20, 0.2)', 'rgba(20, 20, 20, 1)'], | |||
There was a problem hiding this comment.
does this come from some design guide? can this can abstracted for unlimited colors?
There was a problem hiding this comment.
Current Colour scheme looks nice and can well be used, I would not abstract or generalize it: devs should change if they prefer other colour coding
There was a problem hiding this comment.
it seems the original colors come from https://www.chartjs.org/docs/3.9.1/#creating-a-chart example /wo any specific design guide/logic
|
please add a simple demo usage to |
mvorisek
force-pushed
the
feature_stacked_bar_chart
branch
from
f22275d to
837c0c5
Compare
mvorisek
force-pushed
the
feature_stacked_bar_chart
branch
from
837c0c5 to
014bd37
Compare
mvorisek
force-pushed
the
feature_stacked_bar_chart
branch
from
014bd37 to
9d402e2
Compare
|
Added LineChart |
|
|
||
| namespace Atk4\Chart; | ||
|
|
||
| class LineChart extends Chart |
There was a problem hiding this comment.
This complicates any extension in user projects... Not sure if different chart type that does not need additional modifications needs a custom class.
There was a problem hiding this comment.
There can be modifications in future is someone will be ready to contribute them :)
I think each chart type should have it's own class even if it is mostly empty. Also maybe some parts from generic Chart class should go to extended chart classes.
| { | ||
| $this->type = 'horizontalBar'; | ||
|
|
||
| // in chartjs 3.9.1 replace with |
There was a problem hiding this comment.
better to upgrade to the latest lib now
Adding feature to support stacked bars.
Also additional default colour for longer datasets added.