Check existing location tokens on unconditioned model #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jul 5, 2024
| @@ -108,7 +108,7 @@ protected function init(): void | |||
| $this->onHookShort(Model::HOOK_AFTER_DELETE, function () { | |||
| $path = $this->get('location'); | |||
| if ($path && $this->flysystem->fileExists($path)) { | |||
| $files = (clone $this->getModel())->addCondition( | |||
| $files = (new self($this->getModel()->getPersistence()))->addCondition( | |||
There was a problem hiding this comment.
this is not ok as model can be extended/modified
There was a problem hiding this comment.
Hi @mvorisek Thank you for your note, but do not understand what you mean: we need to check unconditioned if other tokens exist with the same location. How do we then accomplish this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File model can have other restrictions, such as
status=draftoris_deleted=true. In this case other existing file links cannot be found, and therefore the physical file is deleted, even though records exist withstatus=linkedoris_deleted=false