Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpunit upgrade, strict types #46

Merged
merged 9 commits into from
Jun 19, 2020
Merged

phpunit upgrade, strict types #46

merged 9 commits into from
Jun 19, 2020

Conversation

DarkSide666
Copy link
Member

No description provided.

@DarkSide666 DarkSide666 marked this pull request as draft June 19, 2020 13:43
@DarkSide666 DarkSide666 requested a review from ibelar June 19, 2020 14:22
@DarkSide666 DarkSide666 marked this pull request as ready for review June 19, 2020 14:23
ibelar
ibelar approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok - but maybe we can use jsToast instead of jsNotify.

src/UserAdmin.php Outdated Show resolved Hide resolved
@DarkSide666 DarkSide666 merged commit 745083e into develop Jun 19, 2020
@DarkSide666 DarkSide666 deleted the feature/support-2.1 branch June 19, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelar ibelar ibelar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkSide666 @ibelar