Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix naming issues; remove duplicate code; add test #59

Merged
merged 5 commits into from
Oct 4, 2020
Merged

fix naming issues; remove duplicate code; add test #59

merged 5 commits into from
Oct 4, 2020

Conversation

PhilippGrashoff
Copy link
Contributor

I dont really get the setup of suggestPassword(). At least the duplicate code is removed with this PR

@DarkSide666 DarkSide666 self-requested a review October 4, 2020 19:42
DarkSide666
DarkSide666 approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DarkSide666 DarkSide666 merged commit 50fee9a into atk4:develop Oct 4, 2020
@PhilippGrashoff
Copy link
Contributor Author

thx for finishing, was busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippGrashoff @DarkSide666