Add - During migration manage hasOne relation type. #16

abbadon1334 · 2019-07-22T10:36:00Z

when styleCi will be ok.
i will review my code directly on critical changes, just two, but i think i need to specify it clearly.

* add transcode table for field type => datatype database * tested on SQLite and MySQL

more space is better than less, this class is very useful during development, after that will be disabled and database must be optimized with other tools. i changed because i had a problem storing serialized EXIF in array datatype

climate error correction

switch to codeformatting PSR-1,PSR-2 add hasOne in Test

…" DB fixed mysql float was mistyped uppercase

…nscoding

codecov · 2019-07-22T10:45:16Z

Codecov Report

Merging #16 into develop will increase coverage by 5.43%.
The diff coverage is 70%.

@@              Coverage Diff              @@
##             develop      #16      +/-   ##
=============================================
+ Coverage      65.82%   71.25%   +5.43%     
- Complexity       131      135       +4     
=============================================
  Files              6        6              
  Lines            316      327      +11     
=============================================
+ Hits             208      233      +25     
+ Misses           108       94      -14

Impacted Files	Coverage Δ	Complexity Δ
src/Migration/PgSQL.php	`0% <0%> (ø)`	`10 <10> (ø)`	⬇️
src/Migration/MySQL.php	`100% <100%> (+9.09%)`	`3 <3> (ø)`	⬇️
src/Migration/SQLite.php	`100% <100%> (ø)`	`1 <1> (ø)`	⬇️
src/Migration.php	`78.15% <72.22%> (+7.89%)`	`87 <72> (+4)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3277bef...2abf7eb. Read the comment docs.

abbadon1334

drop support of php < 7.2.0

abbadon1334 · 2019-07-22T10:50:44Z

composer.json

@@ -15,7 +15,7 @@
        }
    ],
    "require": {
-        "php": ">=7.0.0",
+        "php": ">=7.2.0",


drop php < 7.2.0

abbadon1334 · 2019-07-22T10:51:19Z

src/Migration/MySQL.php

@@ -24,6 +24,7 @@ class MySQL extends \atk4\schema\Migration

    /** @var array use this array in extended classes to overwrite or extend values of default mapping */
    public $mapToAgile = [
+        0           => ['string'],


default field type for Mysql = string

abbadon1334 · 2019-07-22T10:51:49Z

src/Migration/SQLite.php

@@ -7,6 +7,10 @@ class SQLite extends \atk4\schema\Migration
    /** @var string Expression to create primary key */
    public $primary_key_expr = 'integer primary key autoincrement';

+    public $mapToAgile = [
+        0 => ['string'],


default field type for SQLite = string

abbadon1334 · 2019-07-22T10:55:54Z

src/Migration.php

    {
        // remove parenthesis
        $type = trim(preg_replace('/\(.*/', '', strtolower($type)));

-        $map = array_merge($this->defaultMapToAgile, $this->mapToAgile);
+        $map = array_replace($this->defaultMapToAgile, $this->mapToAgile);


this must be array_replace, i think

yes if you use numeric keys then it should be array_replace

abbadon1334 · 2019-07-22T11:09:43Z

src/Migration.php

+            // FieldType is stored in the reference field
+            if ($field->reference instanceof HasOne) {
+
+                // @TODO if this can be done better?


i leave a TODO, probably can done better.
I need to get the field type of the Referenced hasOne.
To find it :

i create the referenced model stored in $field->reference->model, using the actual persistence/connection

i call $refModel->get($field->reference->their_field) but $their_field is protected

i think $their_field must remain protected

for this specific case, i think the best option is to use Reflection

if $their_field is null use $id_field of the referenced model

if try to get the type of this field and if is null i return integer

I use reflection because migration is not a normal "production" and performance are not so important here.

DarkSide666

Theoretically looks good. I didn't actually test. Was just checking code changes and added few comments.

DarkSide666 · 2019-07-24T15:00:22Z

src/Migration.php

+
+                /** @var Model $refModel */
+                $refModel = new $refModelClass($m->persistence);
+                $refModel->getField($their_field);


you don't need this line

DarkSide666 · 2019-07-24T15:02:35Z

src/Migration.php

+                $refModel = new $refModelClass($m->persistence);
+                $refModel->getField($their_field);
+
+                $type = $refModel->getField($their_field)->type ?? 'integer';


what about also checking $m->getField($refModel->our_field ?: 'id')->type before falling back to integer?

i do it before, i should change the name the var to $reference_field in place of $their_filed which is misleading

on line 220 : $their_field = $reference_their_field ?? $field->reference->owner->id_field;

i changed comment and naming to be less missleading

DarkSide666 · 2019-07-24T15:06:23Z

src/Migration.php

    {
        // remove parenthesis
        $type = trim(preg_replace('/\(.*/', '', strtolower($type)));

-        $map = array_merge($this->defaultMapToAgile, $this->mapToAgile);
+        $map = array_replace($this->defaultMapToAgile, $this->mapToAgile);


yes if you use numeric keys then it should be array_replace

DarkSide666 · 2019-07-24T15:12:39Z

src/Migration.php

+     *
+     * @return string
+     */
+    public function getModelPHPCode(string $table, string $model, string $id_field = 'id', string $namespace = '\Your\Project\Models') :string


Why this method is here?
It's of course interesting to have, but I don't see it's relation to atk4\schema.

i removed the method and the related test

abbadon1334 added 15 commits February 4, 2019 10:08

Extend to all DataType options with PHPUnit Tests

8b4e921

* add transcode table for field type => datatype database * tested on SQLite and MySQL

Change default Type from VARCHAR256 to TEXT

cc94b7c

more space is better than less, this class is very useful during development, after that will be disabled and database must be optimized with other tools. i changed because i had a problem storing serialized EXIF in array datatype

Add transcoding for Field Reference_One

d4575af

climate error correction

Reformatting and change variables name

96ae7e7

switch to codeformatting PSR-1,PSR-2 add hasOne in Test

add creation of file models class via console to "reverse engineering…

0d640c1

…" DB fixed mysql float was mistyped uppercase

Add Doc for function createModelFromTable

7f40ebe

Adjust naming for transcodes on SQLite

88ecb3b

add hasOne detect field type

3984000

Remove some editor autoadd - f... phpstorm

b278a6b

format code in ->getTranscodeTypeKeyFromField

3d0a94d

Composer - Drop PHP < 7.2

0707775

Big refactor

d675830

Merge remote-tracking branch 'remotes/atk4/develop' into add-type-tra…

51ab9c6

…nscoding

Merge remote-tracking branch 'remotes/atk4/develop' into add-type-tra…

f06db6a

…nscoding

StyleCi

f18a26c

StyleCi 1

574a1f0

abbadon1334 commented Jul 22, 2019

View reviewed changes

remove php < 7.2 from travis

89e6a3f

abbadon1334 mentioned this pull request Jul 22, 2019

Add Simulation and/or Manual mode #10

Open

DarkSide666 approved these changes Jul 24, 2019

View reviewed changes

DarkSide666 reviewed Jul 24, 2019

View reviewed changes

abbadon1334 added 3 commits July 24, 2019 20:53

Removed function for creation of Model File

58e2879

Refactor variable names and removed extra line

2b27dcd

Refactor 1 comment to be consistent with the others below

2abf7eb

romaninsh merged commit 4a189ee into atk4:develop Aug 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add - During migration manage hasOne relation type. #16

Add - During migration manage hasOne relation type. #16

abbadon1334 commented Jul 22, 2019

codecov bot commented Jul 22, 2019 •

edited

Loading

abbadon1334 left a comment

abbadon1334 Jul 22, 2019

abbadon1334 Jul 22, 2019

abbadon1334 Jul 22, 2019

abbadon1334 Jul 22, 2019

DarkSide666 Jul 24, 2019

abbadon1334 Jul 22, 2019

DarkSide666 left a comment

DarkSide666 Jul 24, 2019

DarkSide666 Jul 24, 2019

abbadon1334 Jul 24, 2019

abbadon1334 Jul 24, 2019

DarkSide666 Jul 24, 2019

DarkSide666 Jul 24, 2019

abbadon1334 Jul 24, 2019

Add - During migration manage hasOne relation type. #16

Add - During migration manage hasOne relation type. #16

Conversation

abbadon1334 commented Jul 22, 2019

codecov bot commented Jul 22, 2019 • edited Loading

Codecov Report

abbadon1334 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DarkSide666 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 22, 2019 •

edited

Loading