CardDeck default UserAction not working

[mkrecek234]

Steps to reproduce:

• add default CardDeck to any view
• set any model to CardDeck
• Press default UserAction 'Add' and enter entity

Error:

• Expected entity, but instance is a model
  

  ui/src/CardDeck.php

  Line 262 in a8a08cf

  if ($action->getModel()->isLoaded() && $card = $this->findCard($action->getModel())) {

and here

ui/src/CardDeck.php

Line 296 in a8a08cf

if (in_array($model->getId(), array_map($mapResults, $model->export([$model->idField])), true)) {

Replacing $action->getModel() by $action->getEntity() also won't fix it...

[mvorisek]

Yes, $action->getModel()->isLoaded() is definitely wrong.

In the past I put a lot of efford into atk4/data#932 but there are some issues & limitations with phpstan itself although I filed and fixed many bugs there... Before releasing v4.0, it would be great if I can manage to run such static analysis at least one locally.

[mvorisek]

Is there any demo in demos/? Or can any existing demo be adjusted with one, two lines to reproduce there?

[mkrecek234]

See https://github.com/atk4/ui/tree/bug/card_deck_add_action
However since save is deactivated in demo, error not triggered.