Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CardDeck action /w entity #1845

Merged
merged 15 commits into from
Aug 31, 2022
Merged

Fix CardDeck action /w entity #1845

merged 15 commits into from
Aug 31, 2022

Conversation

mkrecek234
Copy link
Contributor

@mkrecek234 mkrecek234 commented Aug 31, 2022 •
edited by mvorisek
Loading

fix #1844

@mkrecek234
Activate default Add UserAction in card deck example.
f9403f7 
Since 'Save' is deactivated in demo, error is not triggered though.

Suggest that in repo demos are indeed saving - only for online demo it is not.
@mkrecek234
Allow modification
e21a0a1
@mkrecek234
Fix
dfce57a
@mvorisek mvorisek changed the title Bug/card deck add action Fix CardDeck add action Aug 31, 2022
mvorisek
mvorisek reviewed Aug 31, 2022
View reviewed changes
demos/init-db.php Outdated Show resolved Hide resolved
mvorisek
mvorisek reviewed Aug 31, 2022
View reviewed changes
src/CardDeck.php Outdated Show resolved Hide resolved
mvorisek
mvorisek reviewed Aug 31, 2022
View reviewed changes
src/CardDeck.php Outdated Show resolved Hide resolved
@mvorisek mvorisek changed the title Fix CardDeck add action Fix CardDeck action /w entity Aug 31, 2022
mvorisek
mvorisek requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@mvorisek mvorisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 problems:

  • RO CardDeck demo does not reload after record is added
  • (from chat, unverified) jsExecute is not executed upon edit or delete, only on add

@mvorisek
Copy link
Member

RO CardDeck demo does not reload after record is added

this is a missing feature, opened #1848, not easy to fix

(from chat, unverified) jsExecute is not executed upon edit or delete, only on add

not sure what you meant @mkrecek234, the jsExecute method should be executed, it has the same Model\UserAction::APPLIES_TO_SINGLE_RECORD type as add action - no need for further investigation, the whole execute -> ajax update part must be reworked for #1848

merging, as the subjected #1844 issue is fixed

@mvorisek mvorisek merged commit 2f7182a into develop Aug 31, 2022
@mvorisek mvorisek deleted the bug/card_deck_add_action branch August 31, 2022 21:08
@mvorisek mvorisek mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek requested changes

Assignees
No one assigned
Labels
bug 🪲
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CardDeck default UserAction not working
2 participants
@mkrecek234 @mvorisek