Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Panel Action Executor #1650

Merged
merged 62 commits into from
Oct 5, 2021
Merged

Feature/Panel Action Executor #1650

merged 62 commits into from
Oct 5, 2021

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jul 15, 2021

Another option instead of using Modal for executing Data\UserAction.

  • Will play step within the Right panel.

Merge after #1646

$factory = $app->getExecutorFactory();
$factory->registerTypeExecutor($factory::STEP_EXECUTOR, [PanelExecutor::class]);

Screen Shot 2021-07-15 at 5 03 17 PM

Screen Shot 2021-07-15 at 4 56 07 PM

@ibelar ibelar marked this pull request as ready for review July 25, 2021 14:59
src/CardDeck.php Outdated
@@ -103,7 +103,7 @@ protected function init(): void

if ($this->paginator !== false) {
$this->addPaginator();
$this->stickyGet($this->paginator->name);
$this->issetApp() ? $this->getApp()->stickyGet($this->paginator->name) : $this->stickyGet($this->paginator->name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need global sticky?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove!

src/App.php Outdated Show resolved Hide resolved
src/App.php Outdated Show resolved Hide resolved
@ibelar ibelar merged commit 4bf8f12 into develop Oct 5, 2021
@ibelar ibelar deleted the feature/panel-executor branch October 5, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants