Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove View::content property (and View::set() method) #2073

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Remove View::content property (and View::set() method) #2073

wants to merge 3 commits into from
+200 −136

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 17, 2023 •
edited
Loading

improve #2075

View::set method was too abstract and clean override using LSP was not possible.

If you need View::$content property (and optionally set the data using constructor and/or View::set method), migrate to ViewWithData class.

There were two major usecases for View::$content property / View::set() method:

  • set text data for Content tag
  • set value for form control

@mvorisek mvorisek added the MAJOR label Jun 17, 2023
@mvorisek mvorisek changed the title Drop View::$content/set in favor of ViewWithContent Remove View::$content/set() in favor of ViewWithContent Jun 17, 2023
@mvorisek mvorisek changed the title Remove View::$content/set() in favor of ViewWithContent Remove View::content property (and View::set() method) Jun 17, 2023
@mvorisek mvorisek force-pushed the drop_content_from_view branch 3 times, most recently from 6ac2b18 to 6d053c4 Compare June 18, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MAJOR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvorisek