Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table column tooltip typecast #2076

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix table column tooltip typecast #2076

wants to merge 1 commit into from
+1 −1

Conversation

mkrecek234
Copy link
Contributor

@mkrecek234 mkrecek234 commented Jun 19, 2023 •
edited by mvorisek
Loading

No description provided.

@mkrecek234 mkrecek234 requested a review from mvorisek June 19, 2023 21:55
@mvorisek
Copy link
Member

mvorisek commented Jun 19, 2023 •
edited
Loading

The tooltip should be definitely typecasted. The coverage says it is covered, but I do not think the actual shown string is asserted, so this change should be covered with a Behat test (and preferably with non-string field).

@mvorisek mvorisek removed their request for review June 19, 2023 22:21
@mvorisek mvorisek changed the title Fix missing typecasting for Tooltip fields Allow non-string field in Tooltip Jun 19, 2023
@mvorisek mvorisek mentioned this pull request Nov 10, 2023
Closed
@mvorisek mvorisek marked this pull request as draft January 25, 2024 11:37
@mvorisek mvorisek changed the title Allow non-string field in Tooltip Fix Tooltip value typecast Feb 18, 2024
@mvorisek mvorisek changed the title Fix Tooltip value typecast Fix table column tooltip typecast Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkrecek234 @mvorisek @dtemaster