-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reveal eye to password form control #2219
Merged
Merged
Changes from 7 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
dd32436
Added 'eye-function' to toggle password visibility to form-passwords.
rickyosser 2603659
Fixed coding-style.
rickyosser 2fab4aa
More coding-style fixes.
rickyosser d2e1f26
More coding-style fixes.
rickyosser df58eae
More coding-style fixes.
rickyosser 2033e2c
More coding-style fixes.
rickyosser 4db7fb2
More coding-style fixes.
rickyosser 803eb38
More coding fixes and removal of unused variable.
rickyosser a70548a
More coding fixes and added Override.
rickyosser 7ae6ba1
Hopefully fixed on-click for the eye-button.
rickyosser 43484fb
More coding-style fixes.
rickyosser 0465e40
More coding-style fixes.
rickyosser e804494
More coding-style fixes.
rickyosser f25ebf2
More coding-style fixes.
rickyosser c20806f
More coding-style fixes.
rickyosser f2acc91
More coding-style fixes.
rickyosser 2c780a0
More coding-style fixes.
rickyosser 74477e6
More coding-style fixes.
rickyosser b46ad36
More coding-style fixes.
rickyosser 70ee987
More coding-style fixes.
rickyosser 278e6b7
More coding-style fixes.
rickyosser 5354bfe
Added JsExpression templation.
rickyosser a89083e
Changed JS *_elements to *Elem.
rickyosser 3379a0c
More code-style changes.
rickyosser 731aa26
Added revealEye to password demo in popup.php.
rickyosser 7cb392e
Added behat test for revealEye feature.
rickyosser d3ffba7
Changed behat tests, trial and error method.
rickyosser cde7aa1
Added password to input2.php.
rickyosser 28e86f3
Fixed password without and with revealEye.
rickyosser 2d206c4
Changed behat tests, trial and error method.
rickyosser d4516df
Fixed iconElem in javascript.
rickyosser 177264e
Revert "Fixed iconElem in javascript."
mvorisek 5505bd0
unrevert name - but still wrong, we must pass icon ID, not owning but…
mvorisek 0d2bf39
use "Button::addTo" with correct render region
mvorisek 9c11996
simplify phpdoc
mvorisek 0056683
improve demo
mvorisek eade929
no guessing icon ID
mvorisek ada9e67
no action when disabled for consistency
mvorisek 6881832
fix stan
mvorisek f94b9cd
Test for review of changed revealEye function
rickyosser 9f807c0
Fixed missing comma.
rickyosser 9739fc9
Removed a component used during testing.
rickyosser adf7c32
Removed variable which wasn't used.
rickyosser afd397e
Removed Button as we don't use it anymore.
rickyosser 3782518
Testing transparent button on demo.
rickyosser 7d8ae4e
Changed to added button. (Work with input field on('clicl
rickyosser 45a5426
Added comment.
rickyosser 91667e8
Fixed coding-style.
rickyosser 81cc191
More coding-style fixes.
rickyosser 425990b
More coding-style fixes.
rickyosser 5e9c346
Moved code around so ->revealEyeButton and the ->revealEyeButton->on …
rickyosser 46aa901
Removed test-code.
rickyosser 4f300fe
Removed more test-code.
rickyosser 1822f02
Removed UserAction from variable definition.
rickyosser 8ea89d1
Removed console.logs.
rickyosser d52b59e
Changed using internal Icon to adding an Icon, this works but I need …
rickyosser 5918038
Fixed icon inside field.
rickyosser a0f8e09
Fixed icon variable.
rickyosser 56336d5
Fixed coding style.
rickyosser 2b5b363
Fixed coding style.
rickyosser 139b47a
Fixed coding style.
rickyosser b7907d9
Fixed coding style.
rickyosser 03327a9
Cleaned up code for revealEye.
rickyosser f6d6c9c
Made some behat-test changes.
rickyosser 269edfa
Made some behat-test changes.
rickyosser 675bff6
Made some behat-test changes.
rickyosser 7cb7bc7
Made some behat-test changes.
rickyosser fa4c032
Made some behat-test changes.
rickyosser 88303ed
Made some behat-test changes.
rickyosser 07455b5
Made some behat-test changes.
rickyosser 88dbac6
Made some behat-test changes.
rickyosser ad32451
Made some selector changes to behat-test.
rickyosser 16a9f0a
Removed all JavaScript-code for a plain ATK4 implementation.
rickyosser 573e7f1
Fixed coding style.
rickyosser 7182db6
Fixed coding style.
rickyosser b0728d6
Fixed coding style.
rickyosser e65a235
Fixed coding style.
rickyosser 92f6894
Simplified code, removed unnecessary variables.
rickyosser 0a238af
Fixed coding style.
rickyosser 419adde
Simplified the code. Removed uneccessary code.
rickyosser 19c1ff8
More simplification of the code. Fixed coding style.
rickyosser 6fbc7f8
Changed behat test to reflect changes in the code.
rickyosser d7cf049
Reverted to using Javascript to change the fields type otherwise the …
rickyosser 157792e
fix&improve cs
mvorisek d99fb94
test hide password again
mvorisek 05750aa
test actual reveal
mvorisek 92af85d
make Behat line output short as possible
mvorisek f7a5d16
cleanup
mvorisek e973d4e
enable password reveal by default
mvorisek 8b844c2
grey only if disabled, also improves UX/contract
mvorisek 8f0a511
Keep focus on the input-field.
rickyosser 97bbae4
improve cs
mvorisek b04cadd
fix focus placed to start on reload
mvorisek 924041e
focus input at the end if not focused
mvorisek 271b529
improve phpdoc type
mvorisek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on whatwg/html#7293 it is true that native solution does not exist in all browsers currently.
IE - at least https://stackoverflow.com/questions/61449079/how-to-hide-the-eye-from-a-password-input-in-ms-edge-and-ie#61450596 is needed to supress the native behaviour of IE, or do we want to keep native eye where supported?
Firefox - https://connect.mozilla.org/t5/ideas/add-a-reveal-password-function-for-logins/idi-p/1140 - did you know there is native (but I agree not much intuitive) reveal - can we turn on/off the native one?
Chrome - it seems there is no native solution (except when using 3rd party extension)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I meant a more native ATK4 solution with more Js functions instead of a big javascript blob... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE - I tested Windows 7 and 10, it seems Microsoft does everything to kill IE in favor of Edge - in both systems, when I opened IE, Edge was opened instead. Edge is based on Chrome. And in Edge and Chrome there is no native reveal icon added. So we do not need any additional code to coexist with the native reveal.