Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search simplifications and optimizations #104

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Search simplifications and optimizations #104

merged 13 commits into from
Aug 23, 2023

Conversation

cmgrote
Copy link
Collaborator

@cmgrote cmgrote commented Aug 22, 2023

  • Adds a new FluentSearch approach to searching (no need to know Elastic anymore)
  • Changes default inclusion operation for Bool queries to filter rather than must (for efficiency)

cmgrote added 6 commits August 16, 2023 22:51
@cmgrote
Mark search results as Iterable
6b6a10e 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote
Merge remote-tracking branch 'origin/main' into AM-118
fa80a0b
@cmgrote
Search simplification (in progress)
53bab5d 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote
Combines bool criteria using filter for efficiency, and adds default …
a31095e 
…sort by GUID for stable results across pages

Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote
Search simplification (in progress)
b6fbc4b 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote
Search simplification
b639372 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote cmgrote requested a review from ErnestoLoma August 22, 2023 14:37
@cmgrote
Adds all possible operations for custom metadata fields
4838820 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
ErnestoLoma
ErnestoLoma requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

pyatlan/model/fields/atlan_fields.py Outdated Show resolved Hide resolved
pyatlan/model/fields/atlan_fields.py Outdated Show resolved Hide resolved
pyatlan/model/fluent_search.py Show resolved Hide resolved
cmgrote added 2 commits August 22, 2023 23:55
@cmgrote
Changes per review comments
180dd6a 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote
Removed file that is no longer used (I think?)
970a04b 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote cmgrote requested a review from ErnestoLoma August 22, 2023 22:57
@cmgrote
Copy link
Collaborator Author

cmgrote commented Aug 22, 2023

Can you also double-check the Jinja template I removed is in fact no longer used (assets/referenceable.jinja2)? It looked to me like it's been replaced by other files (I couldn't find any reference to it in the generator code, either)...

@ErnestoLoma
Copy link
Collaborator

Yes it has been replaced by templates/referenceable_attributes.jinja.

ErnestoLoma
ErnestoLoma requested changes Aug 23, 2023
View reviewed changes
pyatlan/model/fields/atlan_fields.py Outdated Show resolved Hide resolved
cmgrote and others added 3 commits August 23, 2023 11:07
@cmgrote
Changes exists -> has_any_value
77276e5 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@ErnestoLoma
Update HISTORY.md
b545432
@ErnestoLoma
Update version.txt
f8b3c9c
@cmgrote
Limit event retrieval to maximum of 1000 in testing
c47a3af 
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@ErnestoLoma ErnestoLoma merged commit d7c28de into main Aug 23, 2023
@ErnestoLoma ErnestoLoma deleted the AM-118 branch August 23, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErnestoLoma ErnestoLoma ErnestoLoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmgrote @ErnestoLoma