Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT-778: Add credential list endpoint to the SDKs #427

Merged
merged 15 commits into from
Nov 25, 2024
Merged

FT-778: Add credential list endpoint to the SDKs #427

merged 15 commits into from
Nov 25, 2024

Conversation

vaibhavatlan
Copy link
Collaborator

Made the following changes:

  1. Add a method called get_all()
  2. Defined a new model called CredentialResponseList
  3. Added a new constant called GET_ALL_CREDENTIALS

Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress!

A few minor changes before we proceed with functional testing:

Since there are some checks failing please fix those issues.

You can use the following commands locally before pushing your commit:

  1. For code formatting: 🧹

    ./pyatlan-formatter
    
  2. For code QA checks (black, flake8, mypy checks): ✅

    ./qa-checks
    

@Aryamanz29 Aryamanz29 added the feature New feature or request label Nov 21, 2024
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
(I'll perform manual testing locally and then merge this ✅)

Let's now add docs for this feature to Atlan Developer Portal. 📝

vaibhavatlan and others added 15 commits November 25, 2024 16:15
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
…flexibility, as some fields were observed to have null values. Updated the filter query parameter to use json.dumps to ensure it is properly stringified as required by the API. Utilized format_path_with_params for consistent query parameter alignment across API request.
@Aryamanz29 Aryamanz29 merged commit fd19d2b into main Nov 25, 2024
36 checks passed
@Aryamanz29 Aryamanz29 deleted the FT-778 branch November 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants