-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FT-778: Add credential list endpoint to the SDKs #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress!
A few minor changes before we proceed with functional testing:
Since there are some checks failing please fix those issues.
You can use the following commands locally before pushing your commit:
-
For code formatting: 🧹
./pyatlan-formatter
-
For code QA checks (
black
,flake8
,mypy
checks): ✅./qa-checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
(I'll perform manual testing locally and then merge this ✅)
Let's now add docs for this feature to Atlan Developer Portal. 📝
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
Co-authored-by: Aryaman <56113566+Aryamanz29@users.noreply.github.com>
…flexibility, as some fields were observed to have null values. Updated the filter query parameter to use json.dumps to ensure it is properly stringified as required by the API. Utilized format_path_with_params for consistent query parameter alignment across API request.
Made the following changes:
get_all()
CredentialResponseList
GET_ALL_CREDENTIALS