Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIN-160 [summary lineage] added LineagePreprocessor to add and delete connectionProcess assets #3794

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rahul-madaan
Copy link

@rahul-madaan rahul-madaan commented Nov 28, 2024

Change description

added LineagePreprocessor to create and delete connectionProcess assets for summary lineage
https://atlanhq.atlassian.net/browse/LIN-160

Test cases:

  1. 2 connections, 1 table in each connection

    • create process between tables
    • connectionProcess gets created
    • __hasLineage of both connection becomes true
    • delete process between tables
    • connectionProcess gets deleted
    • __hasLineage of both connections become false
  2. 3 connections c1,c2,c3, 1 table in each connection

    • create process bw t1, t2
    • create process bw t2, t3
    • connectionProcess gets created

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant