Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1869 Evaluates API cache optimisation. #3819

Merged
merged 8 commits into from
Jan 15, 2025
Merged

DG-1869 Evaluates API cache optimisation. #3819

merged 8 commits into from
Jan 15, 2025

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Dec 4, 2024

Change description

In simple usecase of evaluates API from UI, multiple entities with same entityGuid or entityId were being fetched. for each entityGuid or entityId, we were fetching AtlasEntityHeader from DB, which was unnecessary as calls for same entityGuid or Id were redundant, thus added caching to optimise the flow.

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix Ticket
Testcases

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@hr2904 hr2904 merged commit 396fb19 into master Jan 15, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants