Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domains in path breakdowns #111

Merged
merged 8 commits into from
May 10, 2023
Merged

Add domains in path breakdowns #111

merged 8 commits into from
May 10, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented May 10, 2023

Issue is #110.

Before, breakdown used to be like mentioned in the issue. Now it is like:

{
    "urn:ogf:network:sdx:topology:sax.net": {
        "ingress_port": {
            "id": "urn:ogf:network:sdx:port:zaoxi:A1:2",
            "name": "Novi100:2",
            "short_name": null,
            "node": null,
            "label_range": null,
            "status": null,
            "state": null,
            "private_attributes": null
        },
        "egress_port": {
            "id": "urn:ogf:network:sdx:port:sax:B2:4",
            "label_range": [
                "100-200",
                "10001"
            ],
            "name": "Novi02:4",
            "node": "urn:ogf:network:sdx:node:sax:B2",
            "short_name": "B2:3",
            "status": "up"
        }
    }
}

The critical change is the line where TEManager adds topology the right way, so that TEManager.topology_manager.topology_list is correctly populated, so that TEManager.topology_manager.get_domain_name() returns the domain name instead of None. The rest is mostly noise from testing.

@sajith sajith added bug Something isn't working ci/cd labels May 10, 2023
@sajith sajith self-assigned this May 10, 2023
@sajith sajith requested a review from congwang09 May 10, 2023 14:58
@sajith sajith linked an issue May 10, 2023 that may be closed by this pull request
@sajith sajith merged commit 57189fd into main May 10, 2023
@sajith sajith deleted the 110.breakdown-with-domain branch May 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd
Projects
Development

Successfully merging this pull request may close these issues.

Breakdowns must contain domains
2 participants