Per-domain topology breakdown investigation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API (appears to be) this: > TEManager(topology1, request) > TEManager.add_topology(topology2) > TEManager.add_topology(topology2) TEManager.__init__ internally calls generate_graph_te(); add_topology() does not, so we will have to make an explicit call to generate_graph_te(). Would be nice to simplify this.
YufengXin
approved these changes
May 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is #112.
Basically the big change is changing
TEManager()constructor such that it will acceptNoneas the initial topology. It turned out that sdx-controller has been using the "merged" topology while constructingTEManager, which lead to the issue of resolving a node to the wrong domain.The rest is changes to tests that helped me arrive at the above conclusion. :-)