-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docstring #141
docstring #141
Conversation
black reformatting is different in 3.8 (my Mac) and 3.9 (here)? |
updated my MacOS to Python3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some suggestions about locations of the docstrings. (This PEP might be useful: https://peps.python.org/pep-0257/.)
Not sure the suggestions will be formatted correctly if you accept them, because I made them with GitHub's interface. You might need to run black again.
Please make sure that you have the current version of black, with pip install --upgrade black
. (We should probably pin black at the current major version...)
There probably are other things too that we can do (documenting parameters, following suggestions made by pydocstyle
etc) but this is a good change. :-)
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
Thanks. Fixed. I've updated all the tools after Python upgrade yesterday |
#70.
@sajith already made the constant flag name change.
Used docstring in a few places