Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old breakdown method #151

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Remove old breakdown method #151

merged 5 commits into from
Aug 9, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 8, 2023

Issue is #125. Removes the old breakdown method, which has been duplicated in the new generate_connection_breakdown() method.

@coveralls
Copy link

coveralls commented Aug 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5802308327

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.058%
Totals Coverage Status
Change from base Build 5800663266: 0.02%
Covered Lines: 840
Relevant Lines: 1025
💛 - Coveralls

@sajith sajith self-assigned this Aug 8, 2023
@sajith sajith linked an issue Aug 8, 2023 that may be closed by this pull request
Remove old breakdown method #125
Closed
@sajith sajith requested a review from YufengXin August 8, 2023 22:09
@sajith sajith merged commit ddf0e5e into main Aug 9, 2023
@sajith sajith deleted the 125.remove-old-breakdown branch August 9, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old breakdown method
3 participants
@sajith @coveralls @YufengXin