Merge pull request #6 from atlas-aero/5-improve-qa

Fixed Clippy warnings + added targets to QA pipeline

.github/workflows/qa.yaml

@@ -57,6 +57,8 @@ jobs:
       matrix:
         target:
           - thumbv7m-none-eabi
+          - thumbv8m.main-none-eabihf
+          - riscv32imac-unknown-none-elf
         rust:
           - stable
           - beta

src/guard.rs

@@ -31,7 +31,7 @@ impl<'a, B: Write + Read> LockFreeGuard<'a, B> {
     }
 }
 
-impl<'a, B> RefGuard<B> for LockFreeGuard<'a, B>
+impl<B> RefGuard<B> for LockFreeGuard<'_, B>
 where
     B: Write + Read<u8>,
 {
@@ -63,7 +63,7 @@ impl<'a, B: Write + Read> CsMutexGuard<'a, B> {
 }
 
 #[cfg(feature = "cortex-m")]
-impl<'a, B> RefGuard<B> for CsMutexGuard<'a, B>
+impl<B> RefGuard<B> for CsMutexGuard<'_, B>
 where
     B: Write + Read<u8>,
 {
@@ -96,7 +96,7 @@ impl<'a, B: Write + Read> SpinGuard<'a, B> {
 }
 
 #[cfg(feature = "spin")]
-impl<'a, B> RefGuard<B> for SpinGuard<'a, B>
+impl<B> RefGuard<B> for SpinGuard<'_, B>
 where
     B: Write + Read<u8>,
 {

src/pin_refreshable.rs

@@ -56,7 +56,7 @@ where
     }
 }
 
-impl<'a, B, R> RefreshableInputPin for Pin<'a, B, R, Input, RefreshMode>
+impl<B, R> RefreshableInputPin for Pin<'_, B, R, Input, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -75,7 +75,7 @@ where
     }
 }
 
-impl<'a, B, R> RefreshableOutputPin for Pin<'a, B, R, Output, RefreshMode>
+impl<B, R> RefreshableOutputPin for Pin<'_, B, R, Output, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -94,7 +94,7 @@ where
     }
 }
 
-impl<'a, B, R> Pin<'a, B, R, Output, RefreshMode>
+impl<B, R> Pin<'_, B, R, Output, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -111,7 +111,7 @@ where
     }
 }
 
-impl<'a, B, R> InputPin for Pin<'a, B, R, Input, RefreshMode>
+impl<B, R> InputPin for Pin<'_, B, R, Input, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -133,7 +133,7 @@ where
     }
 }
 
-impl<'a, B, R> OutputPin for Pin<'a, B, R, Output, RefreshMode>
+impl<B, R> OutputPin for Pin<'_, B, R, Output, RefreshMode>
 where
     B: Read + Write,
     R: RefGuard<B>,
@@ -157,7 +157,7 @@ where
     }
 }
 
-impl<'a, B, R> StatefulOutputPin for Pin<'a, B, R, Output, RefreshMode>
+impl<B, R> StatefulOutputPin for Pin<'_, B, R, Output, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -171,7 +171,7 @@ where
     }
 }
 
-impl<'a, B, R> toggleable::Default for Pin<'a, B, R, Output, RefreshMode>
+impl<B, R> toggleable::Default for Pin<'_, B, R, Output, RefreshMode>
 where
     B: Write + Read,
     R: RefGuard<B>,

src/pin_regular.rs

@@ -22,7 +22,7 @@ where
     }
 }
 
-impl<'a, B, R> InputPin for Pin<'a, B, R, Input, RegularAccessMode>
+impl<B, R> InputPin for Pin<'_, B, R, Input, RegularAccessMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -47,7 +47,7 @@ where
     }
 }
 
-impl<'a, B, R> OutputPin for Pin<'a, B, R, Output, RegularAccessMode>
+impl<B, R> OutputPin for Pin<'_, B, R, Output, RegularAccessMode>
 where
     B: Read + Write,
     R: RefGuard<B>,
@@ -74,7 +74,7 @@ where
     }
 }
 
-impl<'a, B, R> StatefulOutputPin for Pin<'a, B, R, Output, RegularAccessMode>
+impl<B, R> StatefulOutputPin for Pin<'_, B, R, Output, RegularAccessMode>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -90,7 +90,7 @@ where
     }
 }
 
-impl<'a, B, R> toggleable::Default for Pin<'a, B, R, Output, RegularAccessMode>
+impl<B, R> toggleable::Default for Pin<'_, B, R, Output, RegularAccessMode>
 where
     B: Write + Read,
     R: RefGuard<B>,

src/pins.rs

@@ -4,10 +4,10 @@
 //!
 //! Due to the I2C overhead, this module offers two options for state management:
 //! * [Regular access mode](RegularAccessMode): The state is synchronously updated when calling
-//! state functions like `is_high()`, causing 1:1 I2C operations for each individual call.
+//!   state functions like `is_high()`, causing 1:1 I2C operations for each individual call.
 //! * [Refresh access mode](RefreshMode): Register states are internally cached. Functions like
-//! `is_high()` are just using the cached state. The state is updated explicitly, but for all pins at once.
-//! In the best case, the I2C overhead is reduced to one eighth. See [below examples](#refreshable-access-mode) for more details.
+//!   `is_high()` are just using the cached state. The state is updated explicitly, but for all pins at once.
+//!   In the best case, the I2C overhead is reduced to one eighth. See [below examples](#refreshable-access-mode) for more details.
 //!
 //! ## Setup
 //! Individual pins can be fetched using [PCA9539](crate::expander::PCA9539) instance.
@@ -199,7 +199,7 @@ impl<B: Write + Read, R: RefGuard<B>> Pins<B, R> {
 /// Currently there are two modes supported:
 /// * Regular: State of the pin is synchronously fetched from I2C bus when calling functions like `is_high()`
 /// * Refreshable: State of all pins is refreshed explicitly and functions like `is_high()` are working on a cached state.
-/// This reducing the I2C overhead
+///   This reducing the I2C overhead
 pub trait AccessMode {}
 
 /// State of the pin is synchronously fetched from I2C bus
@@ -238,7 +238,7 @@ where
     pub(crate) access_mode: PhantomData<A>,
 }
 
-impl<'a, B, R, A> Pin<'a, B, R, Input, A>
+impl<B, R, A> Pin<'_, B, R, Input, A>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -256,7 +256,7 @@ where
     }
 }
 
-impl<'a, B, R, A> Pin<'a, B, R, Output, A>
+impl<B, R, A> Pin<'_, B, R, Output, A>
 where
     B: Write + Read,
     R: RefGuard<B>,
@@ -273,7 +273,7 @@ where
     }
 }
 
-impl<'a, B, M, R, A> Pin<'a, B, R, M, A>
+impl<B, M, R, A> Pin<'_, B, R, M, A>
 where
     B: Write + Read,
     R: RefGuard<B>,