Add no_alloc compatibility #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-meissner
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Thank you! Looks good, just one minor suggestion.
Seems QA action pipeline is currently not triggered by PR.
Could you please adjust
rt-PCA9539/.github/workflows/qa.yaml
Line 3 in 366bc6e
on:
push:
pull_request:
src/expander.rs
Outdated
| ), | ||
| Bank::Bank0 => self | ||
| .bus | ||
| .write(self.address, &[COMMAND_CONF_0, self.configuration_0.as_value().clone()]), |
There was a problem hiding this comment.
As u8 implements the Copy trait, no cloning is required, as also suggested by Clippy.
Please try to dereference/copy instead:
*self.configuration_0.as_value()This also applies to lines 342, 351, 354, 363 and 366.
|
Thanks for the feedback! Let me know if any further changes are needed |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2 -- I haven't run into any issues yet in my usage over the past month.