Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocker-mode seemingly blocks nothing #3218

Closed
apsinthium opened this issue Oct 13, 2023 · 5 comments · Fixed by #3245
Closed

blocker-mode seemingly blocks nothing #3218

apsinthium opened this issue Oct 13, 2023 · 5 comments · Fixed by #3245
Assignees
@aartaka

Comments

@apsinthium
Copy link

apsinthium commented Oct 13, 2023 •
edited
Loading

Describe the bug
With blocker-mode enabled 1, no ads are removed 23.

Note: manually invoking update-hostlists was required to update hostlists

Precise recipe to reproduce the issue
Enable blocker-mode and visit a webpage with ads.

Information

  • OS name+version: Debian GNU/Linux trixie/sid
  • Graphics card and driver: Intel® Graphics (ADL GT2) & NVIDIA GeForce RTX™ 3070 Ti Laptop GPU w/ proprietary NVIDIA drivers
  • Desktop environment / Window manager name+version: GNOME 44.5
  • How you installed Nyxt (Guix pack, package manager, build from source): flatpak via Flathub
  • Information from show-system-information:
Nyxt version: 3.9.0
Renderer: GI-GTK
Operating system kernel: Linux 6.5.0-2-amd64
Lisp implementation: SBCL 2.3.9 (Dynamic space size: 3221225472)
Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :NYXT-3.9 :NYXT-3 :NYXT-3.9.0 :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :FLATPAK :GLOBAL-VARS :CL-FAD :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CL-PPCRE-UNICODE :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE :WEBKIT2 :WEBKIT-2.42.0 :WEBKIT-2.42 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST :WEBKIT2-PASTE-PLAINTEXT :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI :WEBKIT2-MEDIA :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16 :GTK-3-14 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22 :GDK-3-20 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6 :GDK-3-4 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :CLOSER-MOP :GLIB-2-30 :GLIB-2-32 :GLIB-2-34 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46 :GLIB-2-48 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN :PACKAGE-LOCAL-NICKNAMES :SB-LDB :SB-PACKAGE-LOCKS :SB-THREAD :SB-UNICODE :SBCL :UNIX)

ASDF version: 3.3.1
ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY)
Critical dependencies: (/run/build/nyxt/_build/cl-cffi-gtk/gtk/cl-cffi-gtk.asd /run/build/nyxt/_build/cl-gobject-introspection/cl-gobject-introspection.asd /run/build/nyxt/_build/cl-webkit/webkit2/cl-webkit2.asd)

Output when started from a shell

Gtk-Message: 12:35:56.155: Failed to load module "xapp-gtk3-module"
Gtk-Message: 12:35:56.177: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:35:56.177: Failed to load module "canberra-gtk-module"
Nyxt version 3.9.0
<INFO> [12:35:56] Source location: #P"/app/share/nyxt/"
<INFO> [12:35:56] Loading Lisp file #P"/home/absinthium/.config/nyxt/config.lisp".
<INFO> [12:35:56] Listening to socket: #P"/run/user/1000/nyxt/nyxt.socket"
Gtk-Message: 17:35:57.282: Failed to load module "xapp-gtk3-module"
Gtk-Message: 17:35:57.297: Failed to load module "canberra-gtk-module"
Gtk-Message: 17:35:57.298: Failed to load module "canberra-gtk-module"
Failed to create /home/absinthium/.var/app/engineer.atlas.Nyxt/cache for shader cache (No such file or directory)---disabling.
<INFO> [12:35:57] Loading #P"/home/absinthium/.local/share/nyxt/history/default.lisp".
Gtk-Message: 17:35:57.776: Failed to load module "xapp-gtk3-module"
Gtk-Message: 17:35:57.792: Failed to load module "canberra-gtk-module"
Gtk-Message: 17:35:57.792: Failed to load module "canberra-gtk-module"
Failed to create /home/absinthium/.var/app/engineer.atlas.Nyxt/cache for shader cache (No such file or directory)---disabling.
Gtk-Message: 17:35:58.394: Failed to load module "xapp-gtk3-module"
Gtk-Message: 17:35:58.412: Failed to load module "canberra-gtk-module"
Gtk-Message: 17:35:58.413: Failed to load module "canberra-gtk-module"
<INFO> [12:35:58] Loading #P"/home/absinthium/.local/share/nyxt/auto-rules.lisp".
Failed to create /home/absinthium/.var/app/engineer.atlas.Nyxt/cache for shader cache (No such file or directory)---disabling.
Gtk-Message: 17:35:59.898: Failed to load module "xapp-gtk3-module"
Gtk-Message: 17:35:59.914: Failed to load module "canberra-gtk-module"
Gtk-Message: 17:35:59.915: Failed to load module "canberra-gtk-module"
Failed to create /home/absinthium/.var/app/engineer.atlas.Nyxt/cache for shader cache (No such file or directory)---disabling.
@aadcg
Copy link
Member

aadcg commented Oct 20, 2023

CC @aartaka.

@jmercouris
Copy link
Member

@aartaka ?

@aartaka
Copy link
Contributor

aartaka commented Oct 30, 2023

Not sure what's going on. Will investigate tomorrow.

@aartaka
Copy link
Contributor

aartaka commented Oct 31, 2023

I cannot reproduce on YouTube, and blocker-mode seems to block at least part of the URLs on other websites. @apsinthium, any other websites where you can see that change before/after hostlists update?

@apsinthium
Copy link
Author

@aartaka I updated the hostlists before this new test, but 3.9.1 is nearly unusable so it wasn't easy to navigate to many sites without freezing, crashing, et cetera. However, I was able to visit youtube.com, reuters.com, and nytimes.com, respectively. Maybe I'm misunderstanding how the blocker works, but here are some examples of ads still visible:
YouTube
YouTube2
YouTube3

aartaka added a commit that referenced this issue Nov 3, 2023
@aartaka
blocker: Autoload hosts if empty.
05fd2a3 
This ensures that the hostlist file is created if it doesn't exists and that
hosts are fetched if they weren't. Blocker mode is not integrated into Nfiles
properly, but it's a legacy we have to live with: likely, lots of users rely on
it in their config.

Closes #3218.
@aartaka aartaka mentioned this issue Nov 3, 2023
Merged
7 tasks
@aadcg aadcg closed this as completed in 5d52379 Nov 8, 2023
aadcg pushed a commit that referenced this issue Nov 13, 2023
@aartaka @aadcg
mode/blocker: Autoload hosts if empty.
5e80e53 
Ensures that the hostlist file is created and that hosts are fetched. Blocker
mode is not integrated into Nfiles properly, but it's a legacy we have to live
with: likely, lots of users rely on it in their config.

Closes #3218.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aartaka aartaka

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

blocker: Autoload hosts if empty. atlas-engineer/nyxt
4 participants
@jmercouris @aadcg @aartaka @apsinthium