buffer: Review status buffer style. #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lansingthomas
approved these changes
Oct 19, 2023
aadcg
force-pushed
the
review-status-buffer-ui
branch
from
abce1d9 to
8efec46
Compare
|
No need to rush since this is not a priority. You and @jmercouris should take a look together and make a decision. I've just changed something now, while taking a second look. See the recording below. simplescreenrecorder-2023-10-20_10.12.33.mp4 |
|
Looks grand. Will review with John when able. |
Uniformize hover and active CSS pseudo classes across all interactive UI elements. Make use of new theme color and ditch opacity hacks. Review tabs UI.
Status buffer was switched to flexbox, columns were from grid.
jmercouris
force-pushed
the
review-status-buffer-ui
branch
from
36dbf03 to
f1ab2de
Compare
|
I did a rebase since each commit was atomic. |
|
Verdict about selected tab background-color still out, but we will get to it. |
All good. I'd rather have a single commit for such small changes. The authorship of the commit is rather unimportant in my view. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uniformize hover and active CSS pseudo classes across all interactive UI elements.
Make use of new theme color and ditch opacity hacks.
Review tabs UI.
Closes #3142.
Discussion
Currently it's a draft to close the mentioned issue. @jmercouris please demo it with @lansingthomas and make any necessary changes.
Checklist:
Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.
:documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)changelog.lispwith my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).migration.lispentry for all compatibility-breaking changes.