Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electron port CI #3360

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Add electron port CI #3360

merged 6 commits into from
Mar 19, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Mar 18, 2024 •
edited
Loading

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg requested a review from jmercouris March 18, 2024 14:30
@aadcg aadcg force-pushed the add-electron-port-ci branch from f4b507d to c31badf Compare March 18, 2024 14:55
jmercouris
jmercouris approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@jmercouris jmercouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming everything works, I am happy to have both Linux/macOS tested with SBCL. No other comments from me.

@jmercouris
Copy link
Member

Thank you Andre!

@aadcg aadcg force-pushed the add-electron-port-ci branch from c31badf to fa76b2d Compare March 19, 2024 08:44
@aadcg aadcg merged commit 6fa0f6d into master Mar 19, 2024
3 checks passed
@aadcg aadcg deleted the add-electron-port-ci branch March 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmercouris jmercouris jmercouris approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadcg @jmercouris