Input handling refactor #3366
Merged
Input handling refactor #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmercouris
force-pushed
the
input-handling-refactor
branch
4 times, most recently
from
ca748a4 to
68b545c
Compare
|
Will review by tomorrow at the latest. |
It is now done per buffer, instead of per window. Opens possibilities for further simplifying input handling such as having multiple buffers per window or binding keybindings on panel buffers. Disconnect handlers when hiding a buffer on the WebKitGTK port. Prevents the prompt buffer from having unnecessary handlers bound to it as it disappears and appears. Move command-dispatcher slot from window to browser class. Move key-stack and last-key slots from window to buffer class. Delete input-skip-dispatcher slot.
These are problems that GTK should solve, not us. Additionally GTK does not work well on macOS, particularly WebKitGTK+. See NixOS/nixpkgs#126101.
aadcg
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
A very solid step into a much saner implementation. One chunk less of technical debt. Thanks @jmercouris.
The PR introduces a problem on the Electron port but I'll open an issue mentioning it. See #3371.
Merging with minor commit message and changelog edits.
source/changelog.lisp
Outdated
| @@ -27,6 +27,9 @@ | |||
|
|
|||
| (define-version "4.0.0" | |||
| (:ul | |||
| (:li "Refactor input to be handled on the buffer level rather than the window | |||
| level. This will allow panel buffers to have their own hotkeys. It will also | |||
| allow for vertical and horizontal splitting of buffers.") | |||
There was a problem hiding this comment.
The changelog isn't the right place for political campaign, right? 😄
aadcg
force-pushed
the
input-handling-refactor
branch
from
68b545c to
51004e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle input PER buffer, not PER window.
Checklist:
(asdf:test-system :nyxt/<renderer>))