DCA11Y-1315 Use PAC when possible #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalsatl
reviewed
Nov 8, 2024
...gin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java
Show resolved
Hide resolved
rafalsatl
reviewed
Nov 8, 2024
...in/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndPnpmMojo.java
Show resolved
Hide resolved
rafalsatl
reviewed
Nov 8, 2024
frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/Platform.java
Outdated
Show resolved
Hide resolved
rafalsatl
reviewed
Nov 8, 2024
...-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/YarnInstaller.java
Show resolved
Hide resolved
rafalsatl
approved these changes
Nov 8, 2024
Excuse the factoring, it's got enough spaghetti for a whole 'nother generation of Eminem memes. Why? Trying to make it easy to update from upstream. If I was to refactor the existing code we're more likely to get merge-conflicts. I don't see us ever being able to upstream this change so it doesn't make sense for the diff to be optimised for that.
atl-mk
force-pushed
the
issue/master/DCA11Y-1315-use-PAC-when-possible
branch
from
86b0dc9
to
5f5389f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excuse the factoring, it's got enough spaghetti for a whole 'nother generation of Eminem memes. Why? Trying to make it easy to update from upstream. If I was to refactor the existing code we're more likely to get merge-conflicts. I don't see us ever being able to upstream this change so it doesn't make sense for the diff to be optimised for that.
We'll agree on behaviour since I think this is not yet fixed and then I'll add tests (I write tests to describe the desired behaviour)