Optimize resolver with threadlocal caches #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On #10 we have removed `dashmap` from this project dependencies. The reason for that is we were observing an alarming amount of crashes related to memory bugs on that crate on developer machines. We have confirmed that those bugs were in the `dashmap` crate and they stopped happening after it was removed. However, the solution put in place made resolution around 3-5x slower than what it was before with `dashmap` caches. That is due to contention on the `RwLock` hashmap used for resolver internal caches. This change moves those caches to use a thread-local map, which achieves close performance to the `dashmap` solution, around 30% slower. The entire resolution task can be completed very quickly on a large project (few seconds), hence we prefer to have a more stable implementation for now.
| let read = cache.read().unwrap(); | ||
| let cached = read.get(&ret).cloned(); | ||
| drop(read); | ||
| let cached = cache.get(&ret); |
There was a problem hiding this comment.
This is a lot nicer now 👍
MonicaOlejniczak
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #10 we have removed
dashmapfrom this project dependencies.The reason for that is we were observing an alarming amount of crashes
related to memory bugs on that crate on developer machines. We have
confirmed that those bugs were in the
dashmapcrate and they stoppedhappening after it was removed.
However, the solution put in place made resolution around 3-5x slower
than what it was before with
dashmapcaches. That is due to contentionon the
RwLockhashmap used for resolver internal caches.This change moves those caches to use a thread-local map, which achieves
close performance to the
dashmapsolution, around 30% slower.The entire resolution task can be completed very quickly on a large
project (few seconds), hence we prefer to have a more stable
implementation for now.
Motivation
Changes
Move resolver internal caches to use thread-local storage.
Checklist