-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add title attribute to Compiled style tag #1649
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b2531bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -71,7 +71,7 @@ export default new Optimizer<ParcelOptimizerOpts, unknown>({ | |||
.use( | |||
insertAt({ | |||
selector: 'head', | |||
append: '<style>' + stylesheet + '</style>', | |||
append: '<style title="compiled">' + stylesheet + '</style>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, do we inline CSS also in webpack? I don't think I have seen inlineCss
for it
ooh good idea 👍 do you reckon it would be useful to also add this to the SSR styles that have the (perhaps we can use |
We already have some similar behaviour for the runtime, maybe we should match that?
|
hmm yeah maybe we could keep (i'm reluctant to use
|
TBH, I am not sure if this is a valuable change considering these devlop issues . Also, we know that classes starting with
_
are usually Compiled; hence, we can just look for it.However, it may save some keystrokes when debugging :)
Dev mode
It seems that we are having multiple style tags when extraction is not enabled, only one is getting the
title
attributeVS
Prod mode
We can easily discern what style is for Compiled.