ARC-1239: Return 404 instead of 503 if Jira instance is suspended. #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshkay10
approved these changes
May 17, 2022
atrigueiro
deleted the
ARC-1239-check-if-jira-is-running-before-sending-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check after we receive a 503 error from Jira - we now validate if the Jira instance is suspended by checking the
statusendpoint of that instance. If so, we change the error code to 404 on our end and log it as a warning.Tested in staging - triggered a backfill for my suspended Jira instance using the admin API.
This will, hopefully, improve our SLOs, since 503 errors from Jira represent the majority of our SLO failure events.