-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable builds on all branches #383
Conversation
Closes #280 |
@tiedotguy I've also increased the http forwarder test timeout duration to 1.5 seconds as the ARM build sometimes times out in Travis CI, is this an acceptable test degredation for the AMD64 build? 1.5 seconds was derived from the previous failing travis build which indicated a duration of 1.3s |
If we've got tests timing out, that's an indication of a problem somewhere - the purpose of the timeout is to say "hey, this test is slow, if you need to perform a sleep in order to avoid 'raceyness', then the test should be refactored" It's fine to bump it if it's necessary, but we should give a failing test a sniff test to see if it's got bad behavior, and raise an issue to address it if necessary. |
You can also merge without coveralls passing, but give it a quick look and see if there's an actual flakeyness problem, and raise an issue if so - in this case, the report doesn't say anything went down, so I think it's fine. Not certain why it's shown as a decrease in GH. |
From this build result, it seems this is a degradation within the ARM compiled binary. https://app.travis-ci.com/github/atlassian/gostatsd/jobs/533596613#L843
The same benchmark in the AMD build takes a much lower time.
Might be worth raising this as a separate issue, I think the test case itself is fine. |
That's a lot of nanoseconds. Please raise an issue, it should be looked in to. edit: but it's not a blocker |
Issue #384 has been raised, going ahead with this merge to patch the security vulnerability. |
I keep forgetting release builds have their own separate branch, previous attempt at limiting builds ended up disabling release builds.
I have turned off the build on pull request option, since building on every commit to a pushed branch would replace it. This prevents the build from building twice per PR.