Arc 2730 connection wizard #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-connection-wizard
app/jenkins-for-jira-ui/src/App.tsx
Outdated
| @@ -54,7 +54,7 @@ export const environmentSettings = { | |||
|
|
|||
| const AppContainer = styled.div` | |||
| color: #172B4D; | |||
| margin: 24px 36px 24px 0; | |||
| margin: ${token('space.200')}${token('space.400')} ${token('space.300')} ${token('space.0')}; | |||
There was a problem hiding this comment.
Needed to adjust a smidge so figured I'd convert to the Atlassian design system spacing.
| import { css } from '@emotion/css'; | ||
| import { token } from '@atlaskit/tokens'; | ||
|
|
||
| export const orderedList = css` |
There was a problem hiding this comment.
Pulled these out and renamed coz they're being used in a couple of places now.
| @@ -54,7 +54,7 @@ export const environmentSettings = { | |||
|
|
|||
| const AppContainer = styled.div` | |||
| color: #172B4D; | |||
| margin: 24px 36px 24px 0; | |||
| margin: ${token('space.200')} ${token('space.400')} ${token('space.300')} ${token('space.0')}; | |||
There was a problem hiding this comment.
Had to tweak this a little so figured I'd convert to using the Atlassian space styling while I was at it.
| const ConnectionWizard = (): JSX.Element => { | ||
| const handleNavigateToServerNameScreen = (e: React.MouseEvent) => { | ||
| e.preventDefault(); | ||
| // TODO - add onclick in build new server name |
There was a problem hiding this comment.
This will be done when I work on the next screen.
| @@ -1,14 +1,171 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Some tests in here a new but others have been yanked out of ConnectionPanel coz I had to hoist up some of the requests so made more sense to test from the parent component.
joshkay10
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added the Connection Wizard and a bit of refactoring.
Why
So folks looking at the admin page with no servers, have a way to kick off a connection! Refactoring was because I had to pull the request for jenkins servers up one level to determine whether to render the connection panel or connection wizard.
Added feature flags
renovated_jenkins_for_jira_config_flow
Affected issues
Arc-2730
How has this been tested?
Locally and unit tests
What's Next?
Some more content updates