Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 #2388

Closed
ximex opened this issue Apr 6, 2022 · 7 comments
Closed

Support React 18 #2388

ximex opened this issue Apr 6, 2022 · 7 comments

Comments

@ximex
Copy link

ximex commented Apr 6, 2022

add react ^18.0.0 and react-dom ^18.0.0 as peerDependencies

@jacokok
Copy link

jacokok commented Apr 8, 2022

This will be great. Also running strict mode with react 18 does not work.

@100terres
Copy link
Contributor

100terres commented Apr 9, 2022

Hi! As mentionned by @Paul6552, I'll work to add support for react v18 on @react-forked/dnd package. It's a fork of react-beautiful-dnd. You can read this blog post for more info 🙂

I'll keep you updated here in this issue and on the issue on @react-forked/dnd repo.

You can also follow the progress here in this draft PR.

@mehrnaznazari
Copy link

mehrnaznazari commented Jul 12, 2022

@react-forked/dnd doesn't work with React 18 and StrictMode.
https://codesandbox.io/s/determined-bouman-k81oqv

@Xhale1
Copy link

Xhale1 commented Aug 15, 2022

🎉 @hello-pangea/dnd now supports React 18 and react strict mode!

  1. npm install @hello-pangea/dnd
  2. Replace all imports of react-beautiful-dnd with @hello-pangea/dnd
  3. Enjoy :)

@danieldelcore
Copy link
Collaborator

Hey folks, this is available in the latest version. Let's continue the conversation around strictmode here: #2350

@einarq
Copy link

einarq commented Sep 2, 2022

Hey folks, this is available in the latest version. Let's continue the conversation around strictmode here: #2350

You mean there has been a new release of react-beautiful-dnd? Whats the version number?

Also, any plans on fixing the redux warning about the "pure" option being removed?

@danieldelcore
Copy link
Collaborator

https://github.com/atlassian/react-beautiful-dnd/releases

Latest patch should have it 😄.

Sorry no plans there, I've been helping with this lib in a personal capacity at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants