Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised placeholder placement #94

Closed
alexreardon opened this issue Sep 17, 2017 · 4 comments
Closed

Optimised placeholder placement #94

alexreardon opened this issue Sep 17, 2017 · 4 comments

Comments

@alexreardon
Copy link
Collaborator

Right now when you hover over a foreign list the original draggable placeholder remains. This is to avoid the list collapsing. However, I think it would be better to enable the Droppable placeholder for the home list to avoid collapsing but to avoid having a gap in the list.

Full placeholder rules:

  • when dragging over a home list - use the Draggable placeholder
  • when dragging over no list - use the Draggable placeholder
  • when dragging over a foreign list - use the Droppable placeholder in both the home and foreign Droppable.
@alexreardon
Copy link
Collaborator Author

I did a spike of this and it looks quite nice.

@alexreardon alexreardon removed this from the Candy Castle milestone Sep 20, 2017
@souporserious
Copy link

souporserious commented Feb 12, 2018

First, thank you for such a great library! I absolutely love the workflow compared to other react sortable solutions. Any idea on when/if this might land? Just started using this library and would love this feature. I'm mainly using this for multiple vertical lists right now so it's a little wonky with the placeholder left over when moving to a foreign list. I'd love to help out with whatever if possible. Please let me know.

@alexreardon
Copy link
Collaborator Author

I hope to look at this as we updated our placeholder logic for #202

@alexreardon
Copy link
Collaborator Author

See 10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants