Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transitioning between lists #2

Closed
alexreardon opened this issue Aug 10, 2017 · 26 comments · Fixed by #73
Closed

Support transitioning between lists #2

alexreardon opened this issue Aug 10, 2017 · 26 comments · Fixed by #73
Assignees
Milestone

Comments

@alexreardon
Copy link
Collaborator

No description provided.

@NotAmaan
Copy link

@alexreardon, is there a rough ETA on this?

@alexreardon
Copy link
Collaborator Author

We do not really work on ETA's - but we are starting work on this in the next week or two

@alexreardon
Copy link
Collaborator Author

alexreardon commented Aug 24, 2017

Things are well underway for this one!

The result of a whiteboard session with @jaredcrowe

2017-08-24 14 30 54 small

@alexreardon
Copy link
Collaborator Author

The really hard part one about this one will be getting the keyboard story right. We are really sweating the details to make it work as naturally as possible

@dashed
Copy link

dashed commented Aug 24, 2017

@alexreardon will there be support for moving between nested lists?

@alexreardon
Copy link
Collaborator Author

At this stage I will say no - we may look into it in the future though

@NotAmaan
Copy link

@alexreardon I would definitely vote for nested lists as well. I think the whole Drag and Drop behaviour is mostly used for Kanban boards (btw would be sick to see this being used in Trello) and UI/Page/Layout builders. The latter is what I use react-dnd for, can't wait to switch to react-beautiful-dnd though.

@alexreardon
Copy link
Collaborator Author

At this stage we are not targeting support for interacting Draggables between nested lists for the initial version of this. It adds a lot of complexity which will hold up us delivering this feature. We can look into the ability of transitioning between nested lists as a seperate issue in the future

@alexreardon
Copy link
Collaborator Author

Keep in mind that there will be support for dropping on lots of different Droppables - just not nested Droppables initially.

@alexreardon
Copy link
Collaborator Author

Some more thinking about how transitioning between lists with a keyboard will work

2017-08-25 10 29 36
2017-08-25 10 29 28

@alexreardon
Copy link
Collaborator Author

@poryzhao
Copy link

when will be ready to support moving between nested lists?

@alexreardon
Copy link
Collaborator Author

We are looking at landing a whole range of features before looking into transitioning between nested lists

@alexreardon
Copy link
Collaborator Author

It might seem quiet - but we are busy at work with this one! I just had a break through today with keyboard dragging

@alexreardon
Copy link
Collaborator Author

keyboard-transition-preview mov-scaled-0 2

Making some great progress on keyboard transitioning (so hard!!!). The devil is in the details so there is a still a way to go - but getting closer

@alexreardon alexreardon changed the title Support transitioning between vertical lists Support transitioning between lists Sep 6, 2017
@alexreardon
Copy link
Collaborator Author

Still rough, but you can have a play with our work in progress here

Try using the keyboard - it is awesome.

Some of the examples are still a little wonky - still a work in progress

@hakunin
Copy link

hakunin commented Sep 6, 2017

@alexreardon very nice! One thing I could imagine being improved (outside of this PR) is that when the card isn't lifted, the card focus would move so that I can easily select a different one with arrow keys.

@alexreardon
Copy link
Collaborator Author

@hakunin you are welcome to add that on top of the library. You would need to patch the onKeyDown drag handle function and handle the arrow key actions yourself (while a drag is not occurring of course).

When nothing is dragging react-beautiful-dnd does not override any standard browser behaviour. Arrow keys are usually reserved for scrolling the page.

@hakunin
Copy link

hakunin commented Sep 6, 2017

@alexreardon thanks, makes sense. Trello uses hjkl for walking, which is pretty standard so thats what I am going to use as well.

@tobiasandersen
Copy link
Contributor

@alexreardon Crazy stuff, looks absolutely amazing!

@arthcmr
Copy link

arthcmr commented Sep 12, 2017

Can't wait to see progress on this @alexreardon Nice work 🙌

@alexreardon
Copy link
Collaborator Author

We are hoping to ship today or tomorrow!!

@alexreardon
Copy link
Collaborator Author

Shipped!

hi-five

@poryzhao
Copy link

can there only be one placeholder in a board?

@alexreardon
Copy link
Collaborator Author

@poryzhao this needs some more thinking I agree. The challenge with removing the original placeholder is that the list size can collapse. Perhaps it is better to keep the space at the bottom of the list rather than in place. What do others think?

@alexreardon
Copy link
Collaborator Author

@poryzhao I am keen to make this a bit nicer. I created this with my thoughts on it: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants