Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animated droppable placeholder spike #74

Closed

Conversation

jaredcrowe
Copy link
Contributor

A spike of an animated droppable placeholder. My thoughts:

  • It might be better to make placeholder a connected component rather than passing down the phase via props.
  • The way I've done dynamic CSS animations feels a bit 😕. I'm not sure if CSS transitions will work cleanly but it might be worth exploring. Otherwise we might have to do animations with JS.
  • There's probably a layer of memoization and optimisation which could sit on top of some of the functions in here.

Anyway, proof of concept 🤗

@jaredcrowe jaredcrowe force-pushed the jaredcrowe/animated-placeholder branch from 124af62 to 1e133d8 Compare September 7, 2017 00:30
@alexreardon
Copy link
Collaborator

alexreardon commented Sep 7, 2017

As discussed - we will not be tackling this as part of #2 in order to ship the feature a bit quicker. We can add this in afterwards 👍

Issue to track this work: #77

@alexreardon alexreardon closed this Sep 7, 2017
@alexreardon
Copy link
Collaborator

For future purposes: I think it will be cleaner to avoid needing to manage a stylesheet for the animation. We can just use transition and some componentDidMount trickery. Similar to what we do with Reveal in @atlaskit/navigation

@alexreardon alexreardon deleted the jaredcrowe/animated-placeholder branch November 7, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants