Replace invariant with shorter version in production #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
approved these changes
Jun 29, 2018
alexreardon
approved these changes
Jun 29, 2018
| @@ -58,12 +58,11 @@ export default [ | |||
| // Only deep dependency required is React | |||
| external: ['react'], | |||
| plugins: [ | |||
| // Setting production env before running babel etc | |||
| replace({ 'process.env.NODE_ENV': JSON.stringify('production') }), | |||
There was a problem hiding this comment.
Why did this need to move down?
There was a problem hiding this comment.
Because we need to replace NODE_ENV after babel generate them. replace should be always in the end before minification.
|
🤘
…On Sat, 30 Jun 2018 at 9:33 am, Bogdan Chadkin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rollup.config.js
<#597 (comment)>
:
> @@ -58,12 +58,11 @@ export default [
// Only deep dependency required is React
external: ['react'],
plugins: [
- // Setting production env before running babel etc
- replace({ 'process.env.NODE_ENV': JSON.stringify('production') }),
Because we need to replace NODE_ENV after babel generate them. replace
should be always in the end before minification.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#597 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFN7Rp0sLY5Q0l-y0T5BM_ykuK2AKNZks5uBrk9gaJpZM4U85LQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4kb less to parse, 1kb less to load in production